⚡ Bolt: Optimize ADD, SUBTRACT, MULTIPLY VM instructions#1777
Conversation
💡 What: Implemented fast paths in `src/vm/vm.c` for `ADD`, `SUBTRACT`, and `MULTIPLY` VM instructions when both operands are `TYPE_INT32`. 🎯 Why: These operations are extremely common, especially in loops. The fast path directly modifies the values on the stack, bypassing the `BINARY_OP` macro which involves multiple stack pops/pushes and type checks. It uses `__builtin_*_overflow` to ensure safety and correctly fall back to the slower path that handles 64-bit promotion when bounds are exceeded. 📊 Impact: Expected to reduce execution time for tight integer loops by >5% (tested using a 5000x5000 nested integer addition loop). 🔬 Measurement: Verified with `make -C build pascal` and `./Tests/run_pascal_tests.sh`. Can be benchmarked using large integer math loops. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
⚡ Bolt: Optimize ADD, SUBTRACT, MULTIPLY VM instructions
💡 What: Implemented fast paths in
src/vm/vm.cforADD,SUBTRACT, andMULTIPLYVM instructions when both operands areTYPE_INT32.🎯 Why: These operations are extremely common, especially in loops. The fast path directly modifies the values on the stack, bypassing the
BINARY_OPmacro which involves multiple stack pops/pushes and type checks. It uses__builtin_*_overflowto ensure safety and correctly fall back to the slower path that handles 64-bit promotion when bounds are exceeded.📊 Impact: Expected to reduce execution time for tight integer loops by >5% (tested using a 5000x5000 nested integer addition loop).
🔬 Measurement: Verified with
make -C build pascaland./Tests/run_pascal_tests.sh. Can be benchmarked using large integer math loops.PR created automatically by Jules for task 4428333649891824831 started by @emkey1