🎨 Palette: Add missing audio feedback for iOS accessory bar buttons#1778
🎨 Palette: Add missing audio feedback for iOS accessory bar buttons#1778emkey1 wants to merge 2 commits into
Conversation
* Implement UIInputViewAudioFeedback protocol on TerminalKeyInputView. * Return true for enableInputClicksWhenVisible to enable native typing sounds. * Trigger UIDevice.current.playInputClick() on custom accessory bar button taps (Escape, Tab, modifier toggles, navigation arrows, etc.). * Improve user experience by providing expected audio feedback for keyboard interactions on iOS. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
* Implement UIInputViewAudioFeedback protocol on TerminalKeyInputView. * Return true for enableInputClicksWhenVisible to enable native typing sounds. * Trigger UIDevice.current.playInputClick() on custom accessory bar button taps (Escape, Tab, modifier toggles, navigation arrows, etc.). * Improve user experience by providing expected audio feedback for keyboard interactions on iOS. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: Added native keyboard audio feedback (typing sounds) to the custom iOS keyboard accessory bar buttons in the terminal emulator.
🎯 Why: When users tap standard keys on the iOS software keyboard, they hear a distinct typing click (if enabled in settings). However, tapping the custom keys on the accessory bar above the keyboard (like Esc, Tab, arrows, modifier keys) was completely silent. This lack of feedback breaks user expectations and makes the custom keys feel disconnected or unresponsive compared to the native keyboard experience.
♿ Accessibility: This is an auditory accessibility enhancement. Users who rely on auditory feedback to confirm key presses (including those with visual impairments using the keyboard, or users typing quickly without looking at the screen) now receive the same confirmation for custom terminal keys as they do for standard alphanumeric keys.
TerminalKeyInputViewtoUIInputViewAudioFeedbackand setenableInputClicksWhenVisibleto true.UIDevice.current.playInputClick()to all button handlers inTerminalInputBridge.swift..jules/palette.mdjournal.PR created automatically by Jules for task 7688516268390291404 started by @emkey1