Skip to content

Exclude unknown work time from part-time searches - #83

Merged
emnl51 merged 1 commit into
mainfrom
codex/redesign-profile-editor
Sep 4, 2026
Merged

emnl51 merged 1 commit into
mainfrom
codex/redesign-profile-editor

Conversation

@emnl51

@emnl51 emnl51 commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • inspect the title, available description, weekly-hours/workload text, and provider metadata before classifying work time
  • hard-exclude unresolved Work time unknown results from part-time and working-student searches even in preference mode
  • hide previously stored unknown-work-time rows from those profiles immediately after deployment
  • keep confirmed Werkstudent, Teilzeit, Minijob, Nebenjob, Studentenjob, hour, and workload signals
  • apply the rule consistently to dedicated Search Jobs, the legacy/global search path, review lists, details, and notifications
  • update README and the unreleased changelog

Verification

  • 246 pytest tests passed
  • Ruff check and format check passed
  • all JavaScript files passed node --check
  • clean diff check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35ffa384d7

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/profile_store.py
Comment on lines +626 to +627
if profile_requires_confirmed_work_time(profile) and item["employment_type"] == "unknown":
continue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the scoring classifier when filtering saved jobs

Confirmed vacancies are hidden when their work time is expressed only as weekly hours, workload percentage, PART_TIME provider metadata, or signals such as Student Assistant: assess_employment_fit recognizes these as part-time and can score/notify them, but classify_job_metadata still returns employment_type == "unknown". This post-query check consequently removes valid matches from the review queue; the filtering decision should reuse the employment assessment or make the metadata classifier recognize the same confirmation signals.

Useful? React with 馃憤聽/ 馃憥.

Comment thread app/profile_store.py
Comment on lines +626 to +627
if profile_requires_confirmed_work_time(profile) and item["employment_type"] == "unknown":
continue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Filter unknown-work rows before applying LIMIT

When an upgraded database contains legacy non-excluded rows with genuinely unknown work time, the query selects the newest limit rows before this loop discards them. For example, 100 recent unknown rows can make the default API response empty even when older confirmed part-time matches exist, with no offset-based way for the UI to reach them. Apply the exclusion in the query or keep fetching until the requested number of eligible rows is collected.

Useful? React with 馃憤聽/ 馃憥.

@emnl51
emnl51 merged commit 5e3fa4c into main Sep 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant