Prevent runtime environment from overriding release version - #86
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9145e0241
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Do not set `APP_VERSION` in `.env`. Release versions are embedded into the | ||
| container image at build time; a runtime override can otherwise make the UI | ||
| report a stale version. |
There was a problem hiding this comment.
When a source-deployment user follows this new instruction and removes APP_VERSION, the documented docker compose up -d --build path still does not pass an APP_VERSION build argument (docker-compose.yml only specifies build: .). Consequently BERT_BUILD_VERSION is baked as empty and app/version.py falls back to the outdated DEFAULT_VERSION (17.2.2), so fresh source deployments continue reporting the wrong version and reuse the wrong UI cache key. Either inject the actual version for this build path or scope this instruction to prebuilt images.
Useful? React with 👍 / 👎.
| @@ -152,24 +156,6 @@ After signing in as the administrator: | |||
| 4. Configure personal Telegram or email notifications in the user workspace. | |||
| 5. Configure account-activation email under **Administration → System Email**. | |||
|
|
|||
There was a problem hiding this comment.
This version-focused change also removes the recently added explanation of Profile essentials, role-level eligibility, strict working-time behavior, and linked-profile deletion constraints. Administrators consulting the initial-configuration section now lose the detailed guidance needed to understand these non-obvious behaviors; this unrelated deletion should be reverted unless those instructions are deliberately relocated elsewhere.
Useful? React with 👍 / 👎.
1 participant
Summary
BERT_BUILD_VERSIONAPP_VERSIONAPP_VERSIONmust not be stored in.envWhy
The server's
.envcontainedAPP_VERSION=19.1.3, which overrode the freshly built20.1.1image at container startup.Validation
237 passed