fix: rename env.example back to .env.example, add .gitignore - #8
Conversation
env.example (no leading dot) was silently missed by tooling/convention that expects .env.example, so the new SANDBOX_SERVICE_TOKEN / VECTOR_SERVICE_TOKEN / REPUTATION_SERVICE_TOKEN / DEVELOPER_TOKEN_SIGNING_SECRET vars introduced in #5 never made it into anyone's local .env. Renamed back, and added .gitignore so a real .env is never committed going forward.
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36655a18cc
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dist/ | ||
| .next/ | ||
| .turbo/ |
There was a problem hiding this comment.
Ignoring these directories does not affect files already tracked in the index. In the reviewed tree, 108 dist, 214 .next, and 294 .turbo files remain tracked, so subsequent builds will continue to expose their changes in git status and allow generated output to be committed. Remove the existing artifacts from the index as part of this change.
Useful? React with 馃憤聽/ 馃憥.
| .turbo/ | ||
| *.log | ||
| .env | ||
| .env.*.local |
There was a problem hiding this comment.
For developers running the Next.js web app with overrides or credentials in apps/web/.env.local, this pattern does not match .env.local (it only matches names such as .env.development.local). The file therefore remains eligible to be staged and committed, undermining the stated protection against leaking local environment values; add an explicit rule or ignore .env* while exempting .env.example.
Useful? React with 馃憤聽/ 馃憥.
2 participants
#5 renamed .env.example to env.example (dropped the leading dot), which broke the standard convention most tooling and copy-paste habits rely on. The new required vars (SANDBOX_SERVICE_TOKEN, VECTOR_SERVICE_TOKEN, REPUTATION_SERVICE_TOKEN, DEVELOPER_TOKEN_SIGNING_SECRET) never propagated to local .env files as a result. Renamed back and added a .gitignore so a real .env is never accidentally committed.