Skip to content

2.x Prep and base#278

Open
mikeethedude wants to merge 71 commits intodevelopfrom
2.x
Open

2.x Prep and base#278
mikeethedude wants to merge 71 commits intodevelopfrom
2.x

Conversation

@mikeethedude
Copy link
Copy Markdown
Contributor

@mikeethedude mikeethedude commented Jun 17, 2024

Summary

This is where we are starting for 2.x Here are some of the thigs we need to accomplish in this branch.

  • Remove eslint
  • Update or remove chalk
  • Migrate or rebuild as a module type package
  • Update testing requirements
  • Improve Help Text (See comment)
  • Init command should be interactive instead of failing with missing parameters.
  • Fix github actions checks to conform with new stuff

Documentation update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this pull request

  • Pull this code
  • Take note of node version
  • npm run build
  • npm run test - All tests should pass
  • npm link
  • Go to a drupal instance and make sure the node version is the same
  • emulsify init Should take you through a wizard to install
  • go to the theme directory and emulsify system install emulsify-ui-kit
  • Should have UI Kit installed
  • Try and install a component emulsify component install text --force
  • Should install without error!
  • Try adding a component that is not listed in emulsify component list, for example: emulsify component install temp --force
  • You should see the following message:

ERROR Cannot find the definition for component "temp".
Run "emulsify component list" to see the full list.

  • Try adding a component that already exists. The terminal should ask if you want to replace it.

emulsify component install text
? The component "text" already exists. Would you like to replace it? (y/N)

Create standard component:

  • Run emulsify component create card.
  • Select Default and choose a folder.
  • Verify the component structure.
Screenshot 2026-04-10 at 2 17 20 PM

Create SDC component:

  • Run emulsify component create card.
  • Select SDC and verify that 5 files are generated (.twig, .scss, .component.yml, .js, .stories.js).
  • Verify the component structure.
Screenshot 2026-04-10 at 2 18 13 PM

Test overwrite:

  • Run emulsify component create card again.
  • Confirm it asks: Would you like to overwrite it?
  • Try canceling (No) and then overwriting (Yes).

@mikeethedude
Copy link
Copy Markdown
Contributor Author

Holy cow this was hard to get committed. I had to ignore these tests for now. We must clean these up before this is ready:
init.test.ts log.test.ts jsonSchemaToTs.test.ts getInitSuccessMessageForPlatform.test.ts getPlatformInfo.test.ts getAvailableStarters.test.ts

@robherba robherba self-assigned this Dec 23, 2025
@robherba robherba requested a review from josue2591 April 10, 2026 20:34
@robherba robherba added the 👍 Ready for Review Work is ready for review. label Apr 10, 2026
@robherba robherba requested a review from mariannuar April 10, 2026 21:24
Copy link
Copy Markdown

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robherba Most of it looks and works as expected. But when I tried to run the command to add a component that already exists, I got these messages:

Image

@mariannuar mariannuar added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. labels Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👉 Needs Work Reviewer has requested changes.

Projects

No open projects
Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants