Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Trust anchors and pivots 00005#21

Open
MikeCamel wants to merge 6 commits into
enarx-archive:mainfrom
MikeCamel:trust-anchors-and-pivots-00004
Open

Trust anchors and pivots 00005#21
MikeCamel wants to merge 6 commits into
enarx-archive:mainfrom
MikeCamel:trust-anchors-and-pivots-00004

Conversation

@MikeCamel

@MikeCamel MikeCamel commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Was incorrectly named (@axelsimon came in with a 00004 before I submitted this).
First draft.

@mbestavros mbestavros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny spelling correction. Otherwise, this makes a lot of sense to me. Good to codify these definitions.

Comment thread rfc#00005-trust-pivot-introduction Outdated
…st-pivot-introduction

00005 had already been taken. :-(

@npmccallum npmccallum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread rfc#00006-trust-pivot-introduction Outdated
### Trust pivot
A trust pivot is a component which allows a trust relationship
from one entity to another to be transferred, or added, to another
entity. The validity of the pivot assumes the existence of one or more trust anchors.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get an example here? The CA example above made the description more clear. But after reading this I am still not clear on how the trust pivot would work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided a couple. Please let me know what you think.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeCamel Thanks! That works well.

Added examples of trust pivots
Clarified trust pivot definition
lkatalin
lkatalin previously approved these changes Mar 30, 2020

@lkatalin lkatalin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments have been addressed.

@@ -0,0 +1,111 @@
# 00006 Trust anchors and pivots

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC number here is different than the RFC number in the title of this PR.

Comment thread rfc#00006-trust-pivot-introduction.md Outdated
Comment thread rfc#00006-trust-pivot-introduction.md
Comment on lines +48 to +49
relationship to a trust anchor is assumed - based on the endorsing
authority - rather than derived. One example of a trust anchor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the hyphens and add the word "it" to the end of the sentence, so:

"is assumed based on the endorsing authority rather than derived from it."

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble putting it together @connorkuehl, could you use the built-in suggestion tool to suggest a diff/patch? (<ctrl+g> apparently)

Comment thread rfc#00006-trust-pivot-introduction.md Outdated

@axelsimon axelsimon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of interesting ideas and food for thought. I think i'm not the only one for whom more non-technical examples would be helpful, to better grasp the difference between anchors and pivots. I think adding a section that more clearly defines how these two articulate would be very helpful!

Comment on lines +48 to +49
relationship to a trust anchor is assumed - based on the endorsing
authority - rather than derived. One example of a trust anchor

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble putting it together @connorkuehl, could you use the built-in suggestion tool to suggest a diff/patch? (<ctrl+g> apparently)

Comment thread rfc#00006-trust-pivot-introduction.md Outdated
Comment thread rfc#00006-trust-pivot-introduction.md

@lkatalin lkatalin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: Assuming the commits will be squashed.

@mbestavros mbestavros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but it needs a rebase and organizational changes (numbering, according to #22).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants