This repository was archived by the owner on Jun 30, 2020. It is now read-only.
Logfilebuild#32
Open
DK-DARKmatter wants to merge 1 commit into
Open
Conversation
frozencemetery
suggested changes
Mar 27, 2019
frozencemetery
left a comment
frozencemetery
left a comment
Contributor
There was a problem hiding this comment.
You have an extra commit in here.
DK-DARKmatter
force-pushed
the
logfilebuild
branch
from
4cfd7af to
76ea92d
Compare
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
- Coverage 64.87% 64.17% -0.7%
=========================================
Files 13 12 -1
Lines 1170 977 -193
=========================================
- Hits 759 627 -132
+ Misses 411 350 -61
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
- Coverage 64.87% 64.17% -0.7%
=========================================
Files 13 12 -1
Lines 1170 977 -193
=========================================
- Hits 759 627 -132
+ Misses 411 350 -61
Continue to review full report at Codecov.
|
npmccallum
suggested changes
Apr 4, 2019
|
|
||
| openssl = dependency('openssl', version: '>=1.1.0', required: false) | ||
| gnutls = dependency('gnutls', version: '>=3.6.0', required: false) | ||
| gnutls = dependency('gnutls', version: '>=3.6.7', required: false) |
Contributor
There was a problem hiding this comment.
Please remove this change.
We should make sure '--logfile' option is enabled in its new version. If '--logfile' is not an illegal option, then we could enable the tests of gnutls-cli. Signed-off-by: Ke Zhao <kzhao@redhat.com>
DK-DARKmatter
force-pushed
the
logfilebuild
branch
from
76ea92d to
27a0c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update in build file is to make sure
--logfileoption is enabled in its new version.If
--logfileis not an illegal option, then we could enable thetests of
gnutls-cli.