Skip to content

Fixes log rotation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkroo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes log rotation #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb3b217
Disconnect messages from phones, even when not expected, cause channe…
Aug 26, 2015
3766fd0
version bump for fix
Aug 27, 2015
a4a2a9c
Fixes log rotation and removes execute permissions from plain text co…
kkroo Sep 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions GSM/GSML2LAPDm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,14 +762,12 @@ void L2LAPDm::receiveUFrameDM(const L2Frame& frame)

// 5.4.6.2:
switch (mState) {
case LAPDStateUnused:
case LinkReleased:
// GSM 04.06 5.4.5: In idle state all "other" frame types ignored.
return;
case AwaitingRelease:
// GSM 4.06 5.4.4.2
releaseLink(true,L3_RELEASE_CONFIRM);
return;
case LAPDStateUnused:
case LinkReleased:
case AwaitingEstablish:
case LinkEstablished:
case ContentionResolution:
Expand Down
13 changes: 6 additions & 7 deletions apps/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,14 @@ install: OpenBTS OpenBTSCLI
install OpenBTS "$(DESTDIR)/OpenBTS/"
install OpenBTSCLI "$(DESTDIR)/OpenBTS/"
install OpenBTSDo "$(DESTDIR)/OpenBTS/"
chmod +x "$(DESTDIR)/OpenBTS/OpenBTSDo"
install .gdbinit "$(DESTDIR)/OpenBTS/"
install -m 644 .gdbinit "$(DESTDIR)/OpenBTS/"

@shaddi shaddi Sep 10, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a config file, why do we remove the +x?

@kkroo kkroo Sep 10, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using install adds the +x mode to the file so this line is redundant

mkdir -p "$(DESTDIR)/etc/supervisor/conf.d/"
install openbts.conf "$(DESTDIR)/etc/supervisor/conf.d/"
install -m 644 openbts.conf "$(DESTDIR)/etc/supervisor/conf.d/"
mkdir -p "$(DESTDIR)/etc/OpenBTS/"
install iptables.rules "$(DESTDIR)/etc/OpenBTS/"
install OpenBTS.example.sql "$(DESTDIR)/etc/OpenBTS/"
install -m 644 iptables.rules "$(DESTDIR)/etc/OpenBTS/"
install -m 644 OpenBTS.example.sql "$(DESTDIR)/etc/OpenBTS/"
mkdir -p "$(DESTDIR)/etc/rsyslog.d/"
mkdir -p "$(DESTDIR)/etc/logrotate.d/"
install rsyslogd.OpenBTS.conf "$(DESTDIR)/etc/rsyslog.d/OpenBTS.conf"
install logrotated.OpenBTS "$(DESTDIR)/etc/logrotate.d/OpenBTS"
install -m 644 rsyslogd.OpenBTS.conf "$(DESTDIR)/etc/rsyslog.d/OpenBTS.conf"
install -m 644 logrotated.OpenBTS "$(DESTDIR)/etc/logrotate.d/OpenBTS"

12 changes: 12 additions & 0 deletions debian/changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
openbts-public (5.0.9) unstable; urgency=medium

* Fixes log rotation and removes execute permissions from plain text config files

-- Omar Ramadan <omar@endaga.com> Wed, 30 Sep 2015 19:14:36 +0000

openbts-public (5.0.8) unstable; urgency=medium

* Fixes sdcch dead channel issue. Phone could send DM message inappropriately, causing our state machine to get stuck.

-- Kurtis Heimerl <kheimerl@endaga.com> Thu, 27 Aug 2015 13:36:04 -0700

openbts-public (5.0.7) unstable; urgency=medium

* rollback the L3 segfault fix and adds a timeout to sdcch to kill dead channels
Expand Down