Skip to content

chore: enforce green master — clippy lint gates, pre-commit hook, real-LLM council on PRs - #16

Open
enekos wants to merge 1 commit into
masterfrom
chore/lint-gates-and-real-council-ci
Open

enekos wants to merge 1 commit into
masterfrom
chore/lint-gates-and-real-council-ci

Conversation

@enekos

@enekos enekos commented Jul 9, 2026

Copy link
Copy Markdown
Owner

What & why

Repo-hygiene pass to keep master green by construction, plus turning the council self-test into a real dogfooding loop.

  • Workspace clippy gates. [workspace.lints.clippy] denies await_holding_lock, await_holding_refcell_ref, undocumented_unsafe_blocks, and missing_safety_doc; every crate/example/SDK opts in via [lints] workspace = true. Verified green: cargo clippy --workspace --all-targets -- -D warnings.
  • Pre-commit hook. scripts/pre-commit.sh, installed via make install-hooks, runs cargo fmt --check + clippy -D warnings on staged Rust and tsc --noEmit on staged sdk/ts — catches what the lints gate before a CI round-trip.
  • Real-LLM council on PRs. aatxe-council-selftest now auto-promotes pull_request runs to a real-LLM council when a backend secret is present — ANTHROPIC_API_KEY (claude-code, preferred; produced the published 0.857 critical-F1 baseline) else KIMI_API_KEY (pi-proxy). Fork PRs and no-secret repos stay on the free deterministic stub path. Job timeout bumped 10→20m; the claude CLI is installed only for real claude-code runs.
  • .gitignore: tmp/m2/, tmp/perf-vs/.

Notes

Reconstructed from a stale stash (local M1 close-out changes before rebase). The stash's module-refactor and microVM hunks were already merged via #14/#15, so those resolved to master; the only salvaged piece was the install-hooks Makefile target (the hook script was otherwise orphaned). A stray autoresearch.jsonl bench-loop line was left out as unrelated.

…l-LLM council on PRs

- Add [workspace.lints.clippy] denying await_holding_lock,
  await_holding_refcell_ref, undocumented_unsafe_blocks, and
  missing_safety_doc; wire [lints] workspace = true into every crate,
  example, and the rust SDK.
- scripts/pre-commit.sh (installed via `make install-hooks`): runs
  cargo fmt --check + clippy -D warnings on staged Rust and tsc --noEmit
  on staged sdk/ts, so master stays green without a CI round-trip.
- CI: auto-promote the council-selftest to a real-LLM run on
  pull_request when a backend secret is present — ANTHROPIC_API_KEY
  (claude-code, preferred) else KIMI_API_KEY (pi-proxy). Fork PRs and
  no-secret repos stay on the free deterministic stub path. Bump the
  job timeout 10→20m and install the claude CLI only for real
  claude-code runs.
- .gitignore: tmp/m2/, tmp/perf-vs/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant