Conversation
Verified unreachable via `deadcode -test` and `staticcheck`: - cmd/errors.go: unused CLIError type (Error/Unwrap/NewCLIError) - cmd/review_council_cmd.go: orphaned 'review-council' command, never wired into the tree; functionality still reachable via minion - cmd/config.go: GetAPIKey, ProviderTypeFromString, LoadConfigForDirectory (superseded by GetLLMProviderConfig) - tui: unused sineLite helper + userStyle/agentStyle/systemStyle/footerStyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes genuinely-unreachable code from the
mairuGo module. Every removal was confirmed dead by two tools (deadcode -testandstaticcheck); interface-method false positives were deliberately left in place.Removed
internal/cmd/errors.goCLIErrortype (Error/Unwrap/NewCLIError), never adoptedinternal/cmd/review_council_cmd.goreview-councilcobra command, never wired into the tree; the council still runs viaminion_cmd.go, so this was a redundant second entry pointinternal/cmd/config.goGetAPIKey,ProviderTypeFromString,LoadConfigForDirectory(superseded byGetLLMProviderConfig) + now-unused importinternal/acpbridge/bridge.goBridge.Shutdowninternal/tui/chrome.gosineLitehelperinternal/tui/styles.gouserStyle/agentStyle/systemStyle/footerStyleNet: 2 files deleted, ~105 lines removed.
staticcheck U10005→0.Deliberately NOT removed (flagged for your call)
graphListItem/memoryListItem/skillListItem/listItem.Title/.Description/.FilterValue) —deadcodefalse positives; they satisfy the bubbletealist.Iteminterface.trace.WithParent— only writer of a context key still read byParentFromContext; an incomplete feature, not garbage.approved.With{DiffContext,IgnoreFields,FuzzyFields}— unused, but a coherent option-API on a working test helper.Skip_TestContextCommandsEndToEnd(207-line disabled e2e test) —Skip_prefix reads as intentionally parked.go build/go vet/gofmtclean. (acpbridge/TestSessionEchoRoundTripis a pre-existing flaky timing test, unrelated.)