JSON API#5
Open
msp wants to merge 8 commits into
Open
Conversation
Member
Author
|
Hey @guspower, @nurugger07 - I went for a split approach of creating intervening *Attribute types and using a factory to convert one to the other. E.g. the decoders only care about the Bit of duplication in the definition but the type safety/compiler should have our back at the application interface (Widget) and the decoder interface (WidgetAttributes). To review, i'd look at WidgetDecoder & Widget. I followed the same pattern on the other types. Thoughts welcome! |
Still some hard coded parts as we learn..
…ies for construction
msp
force-pushed
the
master
branch
2 times, most recently
from
abb399c to
9efa4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explore decoding JSON API