Skip to content

Add an ability to have custom preview#103

Draft
desfero wants to merge 1 commit into
enesozturk:mainfrom
desfero:custom-preview
Draft

Add an ability to have custom preview#103
desfero wants to merge 1 commit into
enesozturk:mainfrom
desfero:custom-preview

Conversation

@desfero

@desfero desfero commented Jun 23, 2023

Copy link
Copy Markdown

This PR adds an ability to pass custom implementation of the preview component.

Simulator.Screen.Recording.-.iPhone.14.-.2023-06-23.at.16.34.11.mp4

TODO:

  • Cleanup the code
  • Document the changes
  • Understand the best way to have nice animation of reactions once it's hiding from the view.

@NoodleOfDeath

Copy link
Copy Markdown

OHHH I LIKE THIS!! I was trying to add some kind of 'willOpen' property but it needs be synchronously awaited before calculating the size of the component

@desfero

desfero commented Aug 7, 2023

Copy link
Copy Markdown
Author

Don't have time to fully finish this one in the short term future, if anyone wants to continue let me know.

@fukemy

fukemy commented Aug 8, 2023

Copy link
Copy Markdown

hi all, I just want to ask a question:

I saw the lib render {children} 2 times like this:

<GestureHandler>
        <Animated.View ref={containerRef} style={containerStyle}>
          {children} => HERE
        </Animated.View>
      </GestureHandler>

      <Portal key={key} name={key}>
        <Animated.View
          key={key}
          style={portalContainerStyle}
          animatedProps={animatedPortalProps}
        >
          <PortalOverlay />
          {children} => HERE
        </Animated.View>
      </Portal>

So does performance better?

@Etaliya

Etaliya commented Sep 28, 2024

Copy link
Copy Markdown

Is it possible to close it manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants