-
Notifications
You must be signed in to change notification settings - Fork 1
Coverage MOCs: worker-owned leaf tier + end-of-run root (issue 200) #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6f092f8
phase 1 of issue #200
claude 126f160
fold review: tightened box + northern-shard tests (issue #200)
claude 2e94e6c
phase 2 of issue #200
claude eb21f65
fold review: golden bitmap vector + truncation guard (issue #200)
claude f9c4653
phase 3 of issue #200
claude ffeefaa
fold review: union-race posture + coverage test split (issue #200)
claude 13b6b0b
phase 4 of issue #200
claude c504445
phase 5 of issue #200
claude 77dadfe
fold review: round-trip docs example + resilient refresh (issue #200)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 from Claude (review)
should-fix: the root-envelope example is malformed by the implementation's own validation — both ranges would be rejected.
The example declares
"order": 6, but neither endpoint is an order-6 decimal:"-42113221"/"-42113224"are order 7 (base-4+ 7 tail digits) — these were copy-pasted from the leaf example's box members above, which legitimately sit below shard order;"511"is order 2 (base5+ 2 tail digits).Fed to this branch's own readers,
zagg.hive.root_coverage_wordsraisesValueError: malformed coverage range ... at order 6on both ranges (the_decimal_order(lo) == ordercheck atsrc/zagg/hive.py:591), andzagg.coverage._ranges_containnever matches them. Since this example is the field reference a third-party reader (and the frozen mortie-side spec text) will be written against, it should round-trip throughroot_coverage_words. Order-6 endpoints matching the doc's running example would be e.g.:(Everything else in the two envelope examples checks out — I verified the leaf example's
raw_nbytes: 512= ceil(4^6/8) for shard order 6 / cell order 12, and the box members are genuine descendants of-4211322.)Generated by Claude Code