Skip to content

Update interface to count rejections#29

Open
primefac wants to merge 3 commits into
enterprisey:gh-pagesfrom
primefac:patch-1
Open

Update interface to count rejections#29
primefac wants to merge 3 commits into
enterprisey:gh-pagesfrom
primefac:patch-1

Conversation

@primefac

Copy link
Copy Markdown

Rejections have been around for a while but no one noticed that the tool doesn't count them.

Rejections have been around for a while but no one noticed that the tool doesn't count them.
@NovemLinguae

Copy link
Copy Markdown
Collaborator

Thoughts on editing this PR to include your index.html changes, then closing the index.html PR? Would be a bit more organized.

@primefac primefac changed the title Update afchistory.js to count rejections Update interface to count rejections Jun 14, 2026
@primefac

Copy link
Copy Markdown
Author

Good call, done.

@NovemLinguae

NovemLinguae commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Looks pretty good. Rejections are showing up when I visit a page such as file:///f:/other-peoples-githubs/afchistory/index.html?user=Novem%20Linguae . Couple of things though (please fix):

  1. The "Rejected" cell is colored green. Would be better to color this pastel red (same as the "Declined" cells), or maybe even a darker red or a unique color (pastel purple?)
image
  1. Once the page finishes loading, the "Rejected" rows get hidden, even if the "Rejected" filter check box is ticked (it's ticked by default). This is probably a bug involving "Rejected" not being added to a list of states to not auto-hide, or a bug involving the ticked state of the "Rejected" filter check box not being checked once the page finishes loading.

apparently copied the accept colours not the reject
@primefac

primefac commented Jun 16, 2026

Copy link
Copy Markdown
Author

Huh, apparently I copied the wrong colours when I added the row.

I'll have to look into the second issue more... I did wonder why the numbering went 1, 2, 4, 8. I thought adding in 3 would still work but there might be something weird with the show/hide code that I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants