Remove Outdated Python 2.3 Compatibility and Unused Test Utilities. #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused `sys` import and `test_main` function. Streamline `ctypes` imports for better clarity.
Remove `is_resource_enabled` and `requires` functions to simplify test setup.
Removes a `try...except TypeError` block related to `__name__` assignment in `client/lazybind.py`. This compatibility code for Python 2.3's read-only `__name__` attribute is no longer necessary in modern Python versions, simplifying the codebase.
junkmd
added
tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
+ Coverage 87.19% 87.30% +0.10%
==========================================
Files 135 135
Lines 12787 12766 -21
==========================================
- Hits 11150 11145 -5
+ Misses 1637 1621 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request cleans up and simplifies this project by removing old code for Python 2.3 compatibility and eliminating unused utility functions within the test suite.
This enhances the maintainability of the codebase and facilitates future development.
Codebase Simplification
Removal of Outdated Compatibility Code
The
try...except TypeErrorblock inclient/lazybind.py, which handled the read-only behavior of the__name__attribute for Python 2.3, has been removed.This updates the code to modern Python environments, eliminating unnecessary complexity.
Elimination of Unused Test Utilities
The
is_resource_enabledandrequiresfunctions have been removed fromtest/__init__.py. These functions were not actively used by other parts of the test suite, contributing to a simpler test setup.Test Clarification
Streamlining Test Imports
In
test/test_subinterface.py, the unusedsysmodule import and thetest_mainfunction have been removed.This clarifies the intent of the test file and eliminates irrelevant code.