Wrappers for DAP validator functions that throw exceptions#329
Merged
Conversation
Wrapped functions throw an exception rather than returning a success value.
Because why not?
Contributor
|
@bgrant could you add an |
Incidentally, add the test file `distarray/tests/test_testing.py`.
Contributor
Author
|
@kwmsmith : Added some simple tests. |
Contributor
|
LGTM. |
kwmsmith
added a commit
that referenced
this pull request
Apr 21, 2014
…tocol-validator Wrappers for DAP validator functions that throw exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions in the Distributed Array Protocol validator return a
(success, errmsg)tuple; however, when we use them in DistArray, we usually want to throw an exception when a structure doesn't validate. This PR adds three functions totesting.py:which wrap the corresponding DAP validator functions but throw exceptions rather than return tuples. They all use the
raise_exceptiondecorator that I added totesting.py.