Skip to content

Fixes cleanup issues and improves cleanup logic.#331

Merged
cowlicks merged 4 commits into
masterfrom
bugfix/cleanup
Apr 22, 2014
Merged

Fixes cleanup issues and improves cleanup logic.#331
cowlicks merged 4 commits into
masterfrom
bugfix/cleanup

Conversation

@kwmsmith
Copy link
Copy Markdown
Contributor

Caught some big cleanup bugs -- this fixes them.

@kwmsmith kwmsmith mentioned this pull request Apr 21, 2014
@kwmsmith kwmsmith added this to the 0.3 milestone Apr 21, 2014
@kwmsmith kwmsmith added the bug label Apr 21, 2014
@cowlicks
Copy link
Copy Markdown
Contributor

What were there bugs?

@cowlicks
Copy link
Copy Markdown
Contributor

Ah the applysync __name__ thing? Okay, I think this is ready to merge once it is rebased.

@kwmsmith
Copy link
Copy Markdown
Contributor Author

On master, if I run the testsuite and then run the following, it indicates that there are still distarray objects on the engines:

# dump_cluster.py
from __future__ import print_function
from IPython.parallel import Client

c = Client()
dv = c[:]

def count(prefix):
    keys = 0
    for k in globals():
        if k.startswith(prefix):
            keys += 1
    return keys

print(dv.apply_async(count, '__distarray__').get_dict())

The output I get is:

$ python dump_cluster.py
{0: 2102, 1: 1927, 2: 1754, 3: 1680}

After applying this PR, I get zeros for the counts, as it should be.

Kurt Smith added 2 commits April 22, 2014 11:24
Conflicts:
	distarray/context.py
Conflicts:
	distarray/context.py
@kwmsmith
Copy link
Copy Markdown
Contributor Author

@cowlicks merged in master -- this one's ready for merging.

@cowlicks
Copy link
Copy Markdown
Contributor

Looks good, I think. Its hard to tell what merging in master actually did since those commits contain so much unrelated stuff.

cowlicks added a commit that referenced this pull request Apr 22, 2014
Fixes cleanup issues and improves cleanup logic.
@cowlicks cowlicks merged commit 5787e04 into master Apr 22, 2014
@cowlicks cowlicks deleted the bugfix/cleanup branch April 22, 2014 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants