Fixes cleanup issues and improves cleanup logic.#331
Merged
Conversation
Merged
Contributor
|
What were there bugs? |
Contributor
|
Ah the |
Contributor
Author
|
On master, if I run the testsuite and then run the following, it indicates that there are still distarray objects on the engines: # dump_cluster.py
from __future__ import print_function
from IPython.parallel import Client
c = Client()
dv = c[:]
def count(prefix):
keys = 0
for k in globals():
if k.startswith(prefix):
keys += 1
return keys
print(dv.apply_async(count, '__distarray__').get_dict())The output I get is: After applying this PR, I get zeros for the counts, as it should be. |
added 2 commits
April 22, 2014 11:24
Conflicts: distarray/context.py
Conflicts: distarray/context.py
Contributor
Author
|
@cowlicks merged in master -- this one's ready for merging. |
Contributor
|
Looks good, I think. Its hard to tell what merging in master actually did since those commits contain so much unrelated stuff. |
cowlicks
added a commit
that referenced
this pull request
Apr 22, 2014
Fixes cleanup issues and improves cleanup logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught some big cleanup bugs -- this fixes them.