Refactor Distribution creation routines.#332
Merged
Merged
Conversation
There is now a single function for getting a `Map` from a `dist_type`. This pattern was duplicated a lot and is now consolidated in `choose_map`. Renamed `dist` -> `dist_type` in some places for consitency. Renamed `map_factor` -> `map_from_sizes` to be consisten with `map_from_dim_datas` and `map_from_global_dim_dict`.
Distribution.__init__ takes a global dim_data The old Distribution.__init__ is now the Distribution.from_shape classmethod.
kwmsmith
added a commit
that referenced
this pull request
Apr 22, 2014
Refactor Distribution creation routines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in person.
Distribution.__init__takes a global dim_data.Distribution.__init__is now theDistribution.from_shapeclassmethod.This is on top of PR #322