Rename: use dim_data_per_rank consistently#344
Merged
Conversation
in client_map.py.
kwmsmith
added a commit
that referenced
this pull request
Apr 29, 2014
…-consistently Rename: use dim_data_per_rank consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most explicit and general way to specify a LocalArray's distribution is to use the
dim_datastructure from the Distributed Array protocol. When we want to generate several LocalArrays from the client (usually just before packaging them up as a DistArray), we often need a sequence of thesedim_datastructures: one per MPI rank. This structure is referred to as various things in our codebase:dim_datadim_datasdim_data_seqlocal_dim_datasddpp(an abbreviation for an older term,dim_data_per_process)dim_data_per_rankIn this PR, I rename almost all of these to
dim_data_per_rank, except for a couple of situations where I use the abbreviationddpr.dim_data_per_rankis not the most concise, but if we agree on a better term later, it will be easier to do a rename if we use a consistent term now.