Fewer __get/setitem__ roundtrips.#355
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Yes, we definitely need to think about the current ns management...
Contributor
Author
|
rebased |
1 similar comment
Contributor
Author
|
rebased |
Contributor
Author
|
rebase this on PR #366 |
Contributor
Author
|
|
Contributor
|
@cowlicks could you incorporate the new |
Contributor
Author
Contributor
There was a problem hiding this comment.
Please update or remove this comment -- I think that's what made me think you weren't using the new context.apply() method.
kwmsmith
added a commit
that referenced
this pull request
May 13, 2014
Fewer __get/setitem__ roundtrips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
Reimplements
DistArray.__get/setitem__to only use one round trip.