Random array creation takes distribution#360
Merged
kwmsmith merged 13 commits intoMay 5, 2014
Merged
Conversation
instead of shape/dist/grid_shape
Also, fix the tests. All of these functions have been modified to take a distribution as a required argument, whereas before, some of them could be called without shape/dist/grid_shape parameters to return a single scalar. This didn't seem to be an important use-case (one could just use the appropriate numpy function for that), so I omitted it.
Contributor
|
Restarted travis. |
…bution Conflicts: distarray/dist/decorators.py distarray/dist/tests/test_context.py distarray/dist/tests/test_decorators.py distarray/dist/tests/test_distributed_io.py distarray/dist/tests/test_random.py
Merged
Contributor
|
LGTM. Looks like this PR mostly finishes the client-side distribution work and fully integrates distributions with distarrays. We'll see how things shake out interface-wise, but for now I think this is a much cleaner design. |
kwmsmith
added a commit
that referenced
this pull request
May 5, 2014
…takes-distribution Random array creation takes distribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the client-side array-creation methods to take a
Distributionobject instead of theshape,dist,grid_shapearguments directly. A user can create aDistributionobject many ways, including with those arguments. This allows all array-creation routines to create all of our supported distribution types.I modified all
random.pyfunctions to take aDistributionas a required argument, whereas before, some of them could be called withoutshape/dist/grid_shapeparameters to return a single scalar. This didn't seem to be an important use-case (one could just use the appropriatenumpyfunction for that), so I omitted it.