Add Ellipsis support to __getitem__ slicing#385
Merged
Conversation
Merged
Contributor
|
@bgrant are these ellipsis edge cases covered? We should have tests for them: arr = np.ones((10, 20))
assert allclose(arr[..., ..., ...], arr[:, :]) # extra ellipses are ignored.
zerodee = np.array(0)
assert zerodee[...] == zerodee # ellipsis can be used with 0D scalars as well. |
Contributor
Author
|
Regarding how Ellipsis works: it is as described here: http://docs.scipy.org/doc/numpy/reference/arrays.indexing.html But numpy may work differently now (you mentioned in person that the numpy source looked like it had changed). |
Contributor
Author
|
Additional tests added in e394e51 |
Contributor
Author
|
@kwmsmith : Comments addressed. |
And add tests.
|
Changes Unknown when pulling e6f8bdc on feature/add-ellipsis-support-to-slicing into * on master*. |
Contributor
|
👍 |
kwmsmith
added a commit
that referenced
this pull request
Jun 16, 2014
…o-slicing Add Ellipsis support to __getitem__ slicing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #384.
See http://docs.scipy.org/doc/numpy/reference/arrays.indexing.html for details on the Ellipsis object.