Add grid_shape pre/postcondition checks.#427
Merged
Merged
Conversation
Now when the number of distributed dimensions is one, and there are fewer elements than the number of engines. Then distributed dimension will be distributed across 1 engine per element. Previously it was distributed across all engines, but since in this case there are fewer elements than engines, some engines were left with empty distarrays.
Contributor
Author
|
The codebase should now be compliant with the requirements in issue #406 |
Contributor
There was a problem hiding this comment.
ntargets = reduce(operator.mul, grid_shape, 1)
assert ntargets <= len(all_targets)
self.targets = all_targets[:ntargets]?
Contributor
|
👍 |
kwmsmith
added a commit
that referenced
this pull request
Jun 11, 2014
Add grid_shape pre/postcondition checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the checks we want on
grid_shape.Closes #406