Fixes #461.#462
Merged
Merged
Conversation
Contributor
Author
|
@bgrant comment addressed. |
Contributor
|
Looks pretty good. How about a test where |
added 5 commits
June 26, 2014 14:16
Test case added as well. Now 'b' and 'c' are considered compatible if they both have `proc_grid_size == 1` and equal `size`s.
Tests that block cyclic is compatible with block and cyclic when proc_grid_size == 1 and sizes are equivalent.
Changes maps.Distribution -> Distribution. Clean up formatting.
Contributor
Author
|
@bgrant test added. |
Contributor
|
LGTM. I'll merge once Travis finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes
Distribution.is_compatible()to treat 'n' as compatiblewith 'b', 'c', and 'n' when it makes sense to do so.
Closes #461