Attempt at a clearer example of data channels#785
Draft
corranwebster wants to merge 1 commit intomainfrom
Draft
Conversation
corranwebster
commented
Oct 23, 2020
| city = Str() | ||
|
|
||
| country = Str() | ||
| country = Instance(Country, allow_none=True) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| country = Instance(Country, allow_none=True) | |
| country = Instance(Country, allow_none=False) |
D'oh!
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 40.81% 40.88% +0.07%
==========================================
Files 508 508
Lines 27832 27832
Branches 4217 4217
==========================================
+ Hits 11359 11379 +20
+ Misses 15992 15979 -13
+ Partials 481 474 -7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundles country info into an object that contains name and flag information with a custom value type that handles it.
Hopefully this example makes clearer the idea that an item in a model may be more complex than just a scalar value and may have multiple linked data channels.
This is a draft, because it may make sense to bundle this example in with the EnumType PR in some way.