fix(bounty-sidebar): restrict completion rate denominator to terminal bounties#1007
Open
blinkeye-lcm wants to merge 1 commit intoentrius:testfrom
Open
fix(bounty-sidebar): restrict completion rate denominator to terminal bounties#1007blinkeye-lcm wants to merge 1 commit intoentrius:testfrom
blinkeye-lcm wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Completion Rate donut on
/bountieswas computing its center percentage ascompleted / (registered + active + completed + cancelled). Counting queued and in-progress bounties in the denominator pulled the displayed rate down whenever the network had a healthy backlog, even when nearly every finished bounty had completed successfully.This change restricts the denominator to terminal states (
completed + cancelled), so the headline number now reflects the share of resolved bounties that completed rather than the share of all bounties that have already completed. When no bounty has resolved yet, the center renders a neutral placeholder instead of a misleading0%. The donut wedges and the Total Bounties row still show all four status buckets, so backlog visibility is unchanged. The existingrateColorthresholds (50 and 80) stay meaningful since they were calibrated against a true success rate.Related Issues
Fixes #1006
Type of Change
Screenshots
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses