feat(repositories): polish page for mobile - controls, chart#951
Open
syndrome4002-leo wants to merge 2 commits intoentrius:testfrom
Open
feat(repositories): polish page for mobile - controls, chart#951syndrome4002-leo wants to merge 2 commits intoentrius:testfrom
syndrome4002-leo wants to merge 2 commits intoentrius:testfrom
Conversation
Resolve conflict in TopRepositoriesTable.tsx by keeping the mobile-polish layout (compact chart title, responsive search width, separate mobile chart-controls row, responsive chart Collapse padding/height) while adopting main's chartMetricKey-driven chartTopRepositories ranking and compactSortableHeaderSx for list view headers.
Author
|
@ventura-oss Could you please review this PR? |
Contributor
|
|
Author
|
Hello @anderdc Could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Row:+ count + view-toggle →Sort:+ direction icon → chart toggle (with Log Scale switch when chart is open). Search input is always visible — no more icon-toggle.Row:andSort:dropdowns to identical 140px width and matching left edges (36px leading-element width on both rows).xs, and compacted RepositoryCard padding, typography, avatar, and status pill for mobile.TablePaginationtoolbar onxs(smaller min-height, font, action buttons; centered wrapping).ml: auto.360 / 440 / 500), smaller title font (13vs18) with reduced top offset, hide y-axis name onxsso it stops colliding with the title, andtooltip.confine: trueso tooltips no longer get clipped by the parent card'soverflow: hidden.Test plan
/repositories?view=cardsat ≤375px width — verify rows stack in order: filters, search, Row + view-toggle, Sort + direction, chart toggle.Row:andSort:dropdowns share the same width and left edge on mobile.Related Issues
Type of Change
Screenshots
Before:
Now:
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses