fix: base open-discovery repo warning on unique repos#973
Open
hera8939 wants to merge 1 commit intoentrius:testfrom
Open
fix: base open-discovery repo warning on unique repos#973hera8939 wants to merge 1 commit intoentrius:testfrom
hera8939 wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #972.
Fixes the Miner Details open-discovery repo-limit warning so it is based on the number of unique repositories eligible for scanning, not the raw PR count.
The scan helper already de-duplicates PRs by repository before applying the 50-repository cap. The UI warning now uses that same uncapped unique repository count, so miners with many PRs in a small number of repositories no longer see a false repo-limit warning.
Changes
selectMinerIssueScanRepoSummary()to return both capped scan repos and uncapped unique repository count.selectMinerIssueScanRepos()as the existing capped-list API.MinerOpenDiscoveryIssuesByRepoto show the repo-limit warning only when unique repositories exceed the fetch limit.Testing
npm test -- --run src/tests/useMinerRepositoriesOpenIssues.test.ts npx prettier --check src/hooks/useMinerRepositoriesOpenIssues.ts src/components/miners/MinerOpenDiscoveryIssuesByRepo.tsx src/tests/useMinerRepositoriesOpenIssues.test.ts npx eslint src/hooks/useMinerRepositoriesOpenIssues.ts src/components/miners/MinerOpenDiscoveryIssuesByRepo.tsx src/tests/useMinerRepositoriesOpenIssues.test.ts --ext ts,tsx --max-warnings 0 npm run build