Skip to content

refactor: trim HomePage data layer to what the page actually renders #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cleanjunc wants to merge 2 commits into
base: test
Choose a base branch
from
+34 −22
Open

refactor: trim HomePage data layer to what the page actually renders #975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f11fa31
refactor(homepage): drop useDashboardData in favor of direct data hooks
cleanjunc May 7, 2026
b602748
Merge remote-tracking branch 'upstream/test' into homepage-direct-dat…
cleanjunc May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions src/pages/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import {
type CommitLog,
type MinerEvaluation,
type Repository,
useAllMiners,
useAllPrs,
useReposAndWeights,
useStats,
} from '../api';
import { useMonthlyRewards } from '../hooks/useMonthlyRewards';
Expand All @@ -18,9 +21,19 @@ import {
getPrStatusLabel,
parseNumber,
} from '../utils';
import useDashboardData from './dashboard/useDashboardData';
import { buildFeaturedWork } from './dashboard/dashboardData';

const EMPTY_PRS: CommitLog[] = [];
const EMPTY_MINERS: MinerEvaluation[] = [];
const EMPTY_REPOS: Repository[] = [];

const combineQueryState = (
...queries: { isLoading: boolean; isError: boolean }[]
) => ({
isLoading: queries.some((q) => q.isLoading),
isError: queries.some((q) => q.isError),
});

const fadeUp = (delayMs = 0) => ({
opacity: 0,
animation: `landingFadeUp 680ms cubic-bezier(0.16, 1, 0.3, 1) ${delayMs}ms forwards`,
Expand Down Expand Up @@ -298,7 +311,9 @@ const HomePage: React.FC = () => {
}, 7000);
return () => clearInterval(interval);
}, []);
const { datasets, isLoading } = useDashboardData('35d');
const prsQuery = useAllPrs();
const minersQuery = useAllMiners();
const reposQuery = useReposAndWeights();
const stats = useStats();
const onboardLink = useLinkBehavior<HTMLAnchorElement>('/onboard');
const docsLink = useLinkBehavior<HTMLAnchorElement>(
Expand All @@ -308,29 +323,28 @@ const HomePage: React.FC = () => {
'/repository-registration',
);

const minerRows = useMemo(
() => buildTopMinerRows(datasets.miners.data),
[datasets.miners.data],
);
const prs = prsQuery.data ?? EMPTY_PRS;
const miners = minersQuery.data ?? EMPTY_MINERS;
const repos = reposQuery.data ?? EMPTY_REPOS;
const isLoading = prsQuery.isLoading || minersQuery.isLoading;

const minerRows = useMemo(() => buildTopMinerRows(miners), [miners]);
const activityRows = useMemo(
() => buildActivityRows(datasets.prs.data, datasets.repos.data),
[datasets.prs.data, datasets.repos.data],
() => buildActivityRows(prs, repos),
[prs, repos],
);

const mergedPrs35d = useMemo(
() => countMergedPrsInWindow(datasets.prs.data, 35),
[datasets.prs.data],
);
const totalReposEver = datasets.repos.data.length;
const mergedPrs35d = useMemo(() => countMergedPrsInWindow(prs, 35), [prs]);
const totalReposEver = parseNumber(stats.data?.uniqueRepositories ?? 0);
const totalLinesEver = parseNumber(stats.data?.totalLinesChanged ?? 0);
const totalCommitsEver = parseNumber(stats.data?.totalCommits ?? 0);
const totalMergedPrsEver = useMemo(
() => datasets.prs.data.filter((pr) => pr.mergedAt).length,
[datasets.prs.data],
() => prs.filter((pr) => pr.mergedAt).length,
[prs],
);
const totalIssuesSolvedEver = parseNumber(stats.data?.totalIssues ?? 0);
const medianMergeRate = useMemo(() => {
const rates = datasets.miners.data
const rates = miners
.filter((miner) => miner.isEligible)
.map((miner) => {
const merged = parseNumber(miner.totalMergedPrs);
Expand All @@ -345,8 +359,8 @@ const HomePage: React.FC = () => {
const median =
rates.length % 2 === 0 ? (rates[mid - 1] + rates[mid]) / 2 : rates[mid];
return Math.round(median * 100);
}, [datasets.miners.data]);
const minerCount = datasets.miners.data.length;
}, [miners]);
const minerCount = miners.length;
const rewardPoolLabel =
monthlyRewards && monthlyRewards > 0
? formatUsd(monthlyRewards)
Expand Down Expand Up @@ -456,8 +470,7 @@ const HomePage: React.FC = () => {
<LiveProofPanel
rows={activityRows}
hasLiveData={activityRows.length > 0}
isLoading={datasets.prs.isLoading}
isError={datasets.prs.isError}
{...combineQueryState(prsQuery, reposQuery)}
/>
</Box>
<Box
Expand All @@ -477,8 +490,7 @@ const HomePage: React.FC = () => {
<TopMinersPanel
rows={minerRows}
hasLiveData={minerRows.length > 0}
isLoading={datasets.miners.isLoading}
isError={datasets.miners.isError}
{...combineQueryState(minersQuery)}
/>
</Box>
<Stack
Expand Down
Loading