Skip to content

fix(top-miners): rename 'Leaderboard' tab to 'OSS Contributions' (#941)#987

Merged
e35ventura merged 1 commit intoentrius:testfrom
plind-junior:fix/941-oss-contributions-tab
May 9, 2026
Merged

fix(top-miners): rename 'Leaderboard' tab to 'OSS Contributions' (#941)#987
e35ventura merged 1 commit intoentrius:testfrom
plind-junior:fix/941-oss-contributions-tab

Conversation

@plind-junior
Copy link
Copy Markdown
Contributor

Summary

Renames the first timeline tab on /top-miners from "Leaderboard""OSS Contributions" so it's parallel to the sibling "Discoveries" tab and accurately describes the tab's content.

 const TIMELINE_LABELS: Record<TimelineTab, string> = {
-  oss: 'Leaderboard',
+  oss: 'OSS Contributions',
   discoveries: 'Discoveries',
 };

That's the entire change — one line in src/pages/TopMinersPage.tsx.

Why

  • The page itself is the Leaderboard — using "Leaderboard" as one of its sub-tabs is redundant and misleading.
  • The sibling tab is Discoveries (issue-discovery rankings). Renaming this one to OSS Contributions makes the two tabs symmetric and self-describing: OSS Contributions vs. Discoveries.
  • Internally the variant is already keyed as 'oss' and the watchlist UI already uses the "OSS" label for the same dimension — this aligns the user-facing tab with that vocabulary.

Related Issues

Fixes #941

Type of Change

  • Bug fix
  • Refactor (label only — no behavior change)
  • New feature
  • Documentation
  • Other

Out of scope (per #941)

  • No URL param change?timeline=oss stays as the default and existing bookmarks keep working.
  • No SEO/page title change — the page still uses "Leaderboard" as its <title>; that describes the page, not the tab.
  • No route or sidebar nav change/top-miners and the sidebar entry are untouched.

Screenshots

image

Test plan

  • Visit /top-miners — first tab reads "OSS Contributions" and is selected by default.
  • Visit /top-miners?timeline=discoveries — second tab reads "Discoveries" and is selected.
  • Click between the two tabs — URL updates correctly (?timeline=discoveries ↔ no param), table content swaps as before.
  • Existing bookmarks with ?timeline=oss and ?timeline=discoveries still resolve to the correct tab.
  • Browser tab title still says "Leaderboard" (page-level SEO unchanged).

Checklist

  • Uses predefined theme tokens (no hardcoded colors)
  • Responsive/mobile checked — Tabs component already responsive; only the label string changed
  • Tested against the test API
  • npm run format and npm run lint:fix have been run
  • npm run build passes
  • npm test passes (75/75)
  • Screenshots included for UI/visual changes

@xiao-xiao-mao xiao-xiao-mao Bot added the refactor Code restructuring without behavior change label May 7, 2026
@plind-junior
Copy link
Copy Markdown
Contributor Author

@anderdc @e35ventura It's ready for review

@e35ventura e35ventura closed this May 8, 2026
@e35ventura e35ventura reopened this May 9, 2026
@e35ventura e35ventura merged commit aa6b336 into entrius:test May 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code restructuring without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename "Leaderboard" tab to "OSS Contributions" on Top Miners page

2 participants