refactor: unify FilterButton and ExplorerFilterButton into single component#990
Open
bcExpt1123 wants to merge 2 commits intoentrius:testfrom
Open
refactor: unify FilterButton and ExplorerFilterButton into single component#990bcExpt1123 wants to merge 2 commits intoentrius:testfrom
bcExpt1123 wants to merge 2 commits intoentrius:testfrom
Conversation
…ponent - Consolidate duplicate filter pill components into one source of truth - Standardize prop API (use isActive, optional count, add �ctiveTextColor) - Adopt responsive styling from ExplorerFilterButton - Normalize visual styles across all tables for consistency - Migrate all 10 call sites to unified component - Remove ExplorerFilterButton
Collaborator
|
Fix conflicts. |
Contributor
|
Could you please resolve the merge conflicts so we can proceed with the review? |
Contributor
Author
|
Fixed conflicts. please review again. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unified the
FilterButtonandExplorerFilterButtoncomponents into a single, consolidated component to eliminate code duplication and standardize the API across the application. This refactor improves maintainability by centralizing filter pill styling and behavior, adopting responsive design patterns, and normalizing visual consistency across all tables.Key changes include:
selectedtoisActive, madecountoptional, addedactiveTextColor)ExplorerFilterButton(responsive padding, font sizes, etc.)ExplorerFilterButtoncomponentRelated Issues
closes #980
Type of Change
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses