Fix null pointer exception in open PR collateral calculation #138
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a null guard for
repository_tier_configurationincalculate_open_pr_collateral_score()to preventAttributeErrorcrashes when processing open PRs without tier configuration.Problem
The
calculate_open_pr_collateral_score()function accessedpr.repository_tier_configuration.open_pr_collateral_percentagewithout checking ifrepository_tier_configurationwasNone. Sincerepository_tier_configurationis an optional field (defined asOptional[TierConfig] = Noneinclasses.py), this would cause anAttributeErrorwhen processing open PRs from repositories that don't have a tier configuration assigned.Solution
0.0collateral score if tier config is missing (safe default - no penalty applied)Testing
Nonecase gracefully