Write back unrecognized user text tags in Vorbis comments - #24
Open
ElCruncharino wants to merge 1 commit into
Open
Write back unrecognized user text tags in Vorbis comments#24ElCruncharino wants to merge 1 commit into
ElCruncharino wants to merge 1 commit into
Conversation
Reading a Vorbis comment file already preserved any unrecognized field as an INFO_USERTEXT entry, but writing never had a matching branch, so custom tags (anything not in the fixed field list, e.g. a URL field) were silently dropped whenever a file got re-tagged or converted between Vorbis-comment-based formats. id3v2 already round-trips this correctly; mirror the same id/value split here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a Vorbis comment file already preserved any unrecognized field
as an INFO_USERTEXT entry, but writing had no matching case, so custom
tags (e.g. a URL field) were silently dropped whenever a file got
re-tagged or converted between Vorbis-comment-based formats. id3v2
already round-trips this correctly, this mirrors the same approach.
Closes #760