Don't build/install mp4subtitle by default#49
Open
ferdnyc wants to merge 1 commit into
Open
Conversation
The mp4subtitle util has no usable functionality, with all of its features printing "NOT IMPLEMENTED" when activated. So, hide it behind a configuration flag: * `-DBUILD_EXTRA_UTILS=1` (CMake) * `--enable-extra-util` (autotools) And default to not building/installing unless set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mp4subtitleutil has no usable functionality, with all of its features printing "NOT IMPLEMENTED" when activated. So, hide it behind a configuration flag:-DBUILD_EXTRA_UTILS=1(CMake)--enable-extra-util(autotools)And default to not building/installing unless set.
The autotools build will also avoid installing the
mp4subtitle.1man page unless the utility is built.Caveats
The CMake install (silently) makes
BUILD_EXTRA_UTILSdepend onBUILD_UTILS—cmake -DBUILD_UTILS=0 -DBUILD_EXTRA_UTILS=1will still not build/installmp4subtitle.In the autotools build, technically
configure --disable-util --enable-extra-utilwill be accepted, but it will lead to a bad build becauselibmp4v2_la_SOURCESandlibutil_la_SOURCESwon't be configured with the utility source files.If either/both is a major concern, checks for bad combinations of flags can be added.