Conversation
This comment has been minimized.
This comment has been minimized.
buhaiovos
marked this pull request as ready for review
September 14, 2026 15:09
buhaiovos
requested review from
siarhei-fedziukovich and
vladyslavchuhai-spec
as code owners
September 14, 2026 15:09
vladyslavchuhai-spec
approved these changes
Sep 15, 2026
This was referenced Sep 15, 2026
buhaiovos
added this pull request to stack #203
September 16, 2026 09:53
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Problem
run_metric_snapshotslived in the analytics database, but it is not analytics data — it is per-computation configuration (captured metric bindings, declaration versions, output schemas). Sitting there cost three things: no referential integrity (deleteRunsilently orphaned every snapshot row, since no cross-database FK is possible), no joins with run metadata (every consumer read runs from meta and snapshots from analytics and joined in the JVM), and a ClickHouse liability (aUNIQUE(computation_id, tsmd_id)upsert table is exactly what should not be reimplemented on a column store when the analytics vendor is swapped). The REST path/api/v1/analytics/run-metric-snapshotswas already inaccurate, and its OpenAPI example files were misnamed so they were silently never injected. Doing this now unblocks the enriched test-suite-run listing (#197), which needsmetricNamesper run and should be built against the final data shape.Solution
V1.32SQL) withFOREIGN KEY (test_suite_run_id) REFERENCES test_suite_runs(id) ON DELETE CASCADE, and existing rows — which are not regenerable — are copied across by the repository's first Flyway Java migration (V1_33), registered explicitly via.javaMigrations(...)so it can be constructor-injected with the analyticsDataSourceanalyticspackages, qualifiers flip to their meta counterparts/api/v1/run-metric-snapshots, with the old path kept as a separate@Deprecated(forRemoval = true)controller (non-breaking for the UI), and gains the OpenAPI examplesMetaTestDataHelper), with specs and docs synced.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.