Skip to content

feat(analytics): report read failures by error notification instead of inline text - #4552

Merged
dearsimanovich-epam merged 1 commit into
developmentfrom
feat/report-analytics-read-failures-by-notification
Sep 15, 2026
Merged

dearsimanovich-epam merged 1 commit into
developmentfrom
feat/report-analytics-read-failures-by-notification

Conversation

@dearsimanovich-epam

Copy link
Copy Markdown
Contributor

Description:

Analytics reported a failed read by writing a fixed English sentence into the page it was rendering — the same class of event that every other console surface reports through an error notification. Those sentences also said less than the app already knew: the service's errorHeader, errorMessage and requestId were read by BaseApi and then discarded, because the read methods returned T | null, so an operator had no request id to quote at the team running the service. And because the text was inserted into the page's own column flow, it shifted the grid down on arrival and back up on the next successful read.

Analytics read failures now travel as ServerActionResponse envelopes and are reported by error notification in the service's own words, falling back to the existing fixed string only where the service supplied none.

Key Changes:

New Components:

  • useReadFailureNotification — shared hook turning a failed read envelope into an error notification carrying the service's header, message and request id
  • useHopReadReport — the ConversationsTrace inspector's wrapper over that hook for its own client-side hop reads

Breaking Changes:

  • AnalyticsDataApi's 13 read methods return ServerActionResponse<T> instead of T | null; every caller in this repo is updated in the same commit.
  • PipelineReadResult is removed — callers read a refusal off status === 403.

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name ends with (Issue #<ticket>) (comma-separated list of issues)

🤖 Generated with Claude Code

…f inline text

Analytics read failures now travel as ServerActionResponse envelopes and are
reported by error notification in the service's own words, so an operator sees
the service's errorHeader/errorMessage and can quote a requestId. Nine inline
failure texts are removed across Evaluators, Pipelines and ConversationsTrace;
AnalyticsDataApi's 13 reads move from `T | null` to the envelope, and
PipelineReadResult is retired in favour of reading a refusal off `status === 403`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@dearsimanovich-epam
dearsimanovich-epam merged commit 7f8d4c2 into development Sep 15, 2026
13 checks passed
@dearsimanovich-epam
dearsimanovich-epam deleted the feat/report-analytics-read-failures-by-notification branch September 15, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants