Skip to content

[Toolset] OAuth Client secret is displayed in plain text instead of being masked #8791

Description

@dariacherepanova

DIAL chat version

0.0.1

How to reproduce

  1. Open the Toolset Editor.
  2. Select OAuth authentication.
  3. Select Custom login.
  4. Enter a Client ID, e.g. qa-toolset-client-8358.
  5. Enter a Client secret, e.g. qa-toolset-secret-8358.
  6. Observe the Client secret field.
  7. Save the toolset and reopen it in Edit mode.
  8. Observe the Client secret field again.

Actual result

The Client secret is displayed as plain text:

qa-toolset-secret-8358

The secret remains readable in the UI.

Before user tried to log in:

Image

After user tried log in:

Image

Expected result

According to the design, the Client secret must be masked and must not be displayed as plain text.

Image

For example:

••••••••••••

The Client secret should remain masked:

  • while typing;
  • after pasting a value;
  • after authentication/login;
  • when reopening an existing toolset in Edit mode.

When editing an existing toolset, the UI should indicate that a Client secret is already configured without exposing its actual value.

If the user does not change the Client secret and saves other toolset changes, the existing secret must remain unchanged.

Confidential information

  • I confirm that do not share any confidential information

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2 – HighFeature works partially or is broken for a specific segment. A workaround exists but is inconvenientbugSomething isn't working

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions