Skip to content

fix: preserve trailing slash on relative URLs #80 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-novikov merged 3 commits into from
May 14, 2026
Merged

fix: preserve trailing slash on relative URLs #80 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4063ec0
fix: preserve trailing slash on relative URLs #80
andrii-novikov May 13, 2026
a90776c
test: assert full prepared URL instead of just the path
andrii-novikov May 13, 2026
38e3d4d
chore: fix linter
andrii-novikov May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aidial_client/_http_client/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _prepare_url(self, url: str) -> httpx.URL:
merge_raw_path = (
self.base_url.raw_path + parsed_url.raw_path.lstrip(b"/")
)
return self.base_url.copy_with(raw_path=merge_raw_path.rstrip(b"/"))
return self.base_url.copy_with(raw_path=merge_raw_path)
return parsed_url

def _build_request(
Expand Down
32 changes: 32 additions & 0 deletions tests/test_prepare_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import pytest

from aidial_client import AsyncDial, Dial

BASE_URL = "http://localhost:8090"


@pytest.fixture(params=[Dial, AsyncDial])
def client(request):
return request.param(base_url=BASE_URL, api_key="dummy")


@pytest.mark.parametrize(
"relative,expected_url",
[
(
"v1/metadata/files/bucket/appdata/app/",
f"{BASE_URL}/v1/metadata/files/bucket/appdata/app/",
),
(
"v1/metadata/files/bucket/appdata/app",
f"{BASE_URL}/v1/metadata/files/bucket/appdata/app",
),
("/v1/foo/", f"{BASE_URL}/v1/foo/"),
("v1/x/?foo=1", f"{BASE_URL}/v1/x/?foo=1"),
("/", f"{BASE_URL}/"),
("", f"{BASE_URL}/"),
],
)
def test_prepare_url_preserves_trailing_slash(client, relative, expected_url):
prepared = client._http_client._prepare_url(relative)
assert str(prepared) == expected_url
Loading