Conversation
…plications For schema-rich Applications (those with applicationTypeSchemaId), an instance's own mcp.allowedTools now intersects with (narrows) the application type's dial:applicationTypeMcp.dial:allowedTools, instead of being ignored. This allows individual application instances to further restrict which MCP tools they expose, while the application type still defines the base set of allowed tools. The instance can only narrow the type's list, never widen it: - Type's allowedTools: ["tool1", "tool2"] - Instance's allowedTools: ["tool1", "other_tool"] - Effective: ["tool1"] (intersection) If the type's allowedTools is empty (unrestricted), the instance's list is used as-is. Changes: - ApplicationSchemaService.getMcp(): implements intersection logic before returning - ApplicationSchemaServiceTest: unit tests for no-override, intersection, and unrestricted-type cases - CustomApplicationApiTest: E2E test exercising tools/list and tools/call filtering - Schema/docs: updated custom-application-schemas/schema.json, applications.md, and open_api_core.yaml to document the new narrowing behavior
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[…](feat: allow per-instance allowedTools override for schema-rich MCP applications
For schema-rich Applications (those with applicationTypeSchemaId), an instance's own mcp.allowedTools now intersects with (narrows) the application type's dial:applicationTypeMcp.dial:allowedTools, instead of being ignored.
This allows individual application instances to further restrict which MCP tools they expose, while the application type still defines the base set of allowed tools. The instance can only narrow the type's list, never widen it:
If the type's allowedTools is empty (unrestricted), the instance's list is used as-is.
Changes:
Applicable issues
Description of changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.