feat: extend unified chat completion request with custom skills #1955 - #1956
Merged
Merged
Conversation
Adds messages[*].custom_content.skills[*] so callers can reference existing Skill resources per-request, auto-shared into ApiKeyData.attachedSkills the same way file attachments already are.
Oleksii-Klimov
previously approved these changes
Sep 10, 2026
docs/open_api_core.yaml is a generated+merged artifact: schemas without a real Java DTO are sourced from hand-authored fragments under openapi-generator/src/main/resources/schemas/, and SpecMerger deletes any top-level schema in the manual doc that isn't backed by one. The RequestSkill schema added directly to docs/open_api_core.yaml was being dropped as orphaned, breaking `./gradlew replaceSpec -Plint`. Add the RequestSkill fragment and reference it from the two CustomContent fragments instead, then regenerate the doc through the real pipeline.
This comment has been minimized.
This comment has been minimized.
Oleksii-Klimov
approved these changes
Sep 10, 2026
Collaborator
Author
|
/deploy-review
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
2 tasks
andrii-novikov
added a commit
to epam/ai-dial-quickapps-backend
that referenced
this pull request
Sep 14, 2026
A skill reaches a QuickApp agent only if the app author attached it and the model decides to call read_skill — the user has no deterministic way to say "use this skill for this message", and no way in at all for skills from their own catalog. This design specifies how QuickApps consumes the custom_content.skills wire contract agreed with DIAL Core (epam/ai-dial-core#1956): resolve each picked skill through DialSkillResolver, register it under a collision-free user:<name>:<hash> id, and inject a synthetic read_skill call and result after the user message so the manifest is in context before the model's turn. Phase 1 covers the user's own skills; picking the agent's own skills is deferred to #550. Claude-Session: https://claude.ai/code/session_0184dFYXFuKAjivbVvNxL2fa
andrii-novikov
added a commit
to epam/ai-dial-quickapps-backend
that referenced
this pull request
Sep 14, 2026
A skill reaches a QuickApp agent only if the app author attached it and the model decides to call read_skill — the user has no deterministic way to say "use this skill for this message", and no way in at all for skills from their own catalog. This design specifies how QuickApps consumes the custom_content.skills wire contract agreed with DIAL Core (epam/ai-dial-core#1956): resolve each picked skill through DialSkillResolver, register it under a collision-free user:<name>:<hash> id, and inject a synthetic read_skill call and result after the user message so the manifest is in context before the model's turn. Phase 1 covers the user's own skills; picking the agent's own skills is deferred to #550. Claude-Session: https://claude.ai/code/session_0184dFYXFuKAjivbVvNxL2fa
6 tasks
andrii-novikov
added a commit
to epam/ai-dial-quickapps-backend
that referenced
this pull request
Sep 14, 2026
A skill reaches a QuickApp agent only if the app author attached it and the model decides to call read_skill — the user has no deterministic way to say "use this skill for this message", and no way in at all for skills from their own catalog. This design specifies how QuickApps consumes the custom_content.skills wire contract agreed with DIAL Core (epam/ai-dial-core#1956): resolve each picked skill through DialSkillResolver, register it under a collision-free user:<name>:<hash> id, and inject a synthetic read_skill call and result after the user message so the manifest is in context before the model's turn. Phase 1 covers the user's own skills; picking the agent's own skills is deferred to #550. Claude-Session: https://claude.ai/code/session_0184dFYXFuKAjivbVvNxL2fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
messages[*].custom_content.skills[*]to the unified chat completion request so a caller can reference an existing Skill resource per-request, the same waycustom_content.attachments[*]already lets a caller reference a file. Referenced skills are auto-shared to the invoked deployment into the existingApiKeyData.attachedSkillsbucket, the same one Application-config-declared skills already use.Applicable issues
Description of changes
RequestObject— newcollectSkills()default method (no-op for the Anthropic Messages / OpenAI Responses adapters, which are out of scope).ChatCompletionRequest— overridescollectSkills()to scan$.messages[*].custom_content.skills[*].ChatUtil— newcollectCustomSkills/readCustomSkill, throwing400on a missing/blankurl(per current code-style guidance for new code, rather than silently skipping like the legacy attachment parser).CollectRequestSkillsFn(new) — resolves each URL, rejects non-SKILLresource types with400, skips public skills, and otherwise checksAccessService.hasReadAccess, sharing intoattachedSkillsor throwing403.DeploymentPostController— wiresCollectRequestSkillsFninto the request enhancement chain alongside the existing attachment collector.docs/open_api_core.yaml— newRequestSkillschema;skillsarray added to both user and assistant message custom content schemas.ChatCompletionRequestTest(collection),CollectRequestSkillsFnTest(readable/public/denied/wrong-type/absolute-URL branches), and three newDeploymentPostControllerTestcases exercising the fullhandleRequestBodychain (auto-shared, 403, 400).Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.