fix: accept interfaces as the only routing target for applications - #1977
Merged
Merged
Conversation
khshanovskyi
requested review from
Oleksii-Klimov and
astsiapanay
as code owners
September 14, 2026 14:23
This comment has been minimized.
This comment has been minimized.
KirylKurnosenka
approved these changes
Sep 14, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
interfaceswith400 At least application endpoint, MCP endpoint or function must be provided— a check inApplicationServicethat predates the typedinterfacesmap, while the same shape loaded from the config file routes normally.DeploymentEndpointUtil.hasRoutingInterface(deployment): theinterfacesmap contributes a servable type — an entry carrying a translator reference or a url of its own (the deployment-levelbaseUrlincluded), or one whose type a legacy field also serves. An entry resolving to nothing is not a routing target, mirroring the 503 the request path answers for that same shape.ApplicationService.prepareApplicationnow accepts such applications, and the validation message names the interface option.ApplicationInterfacesApiTest(an interfaces-only application is stored and serves through the interface; an entry without any url is still rejected) plus branch coverage forhasRoutingInterfaceinDeploymentEndpointUtilTest.Fixes #1965
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.