fix: 403 error when get shared skill item metadata #1974 - #1978
Merged
Merged
Conversation
The v2 skills metadata route always built its access-check resource with a forced trailing slash, so a share recorded against a specific skill item (non-folder url) never matched. Check both the item-shaped and folder-shaped candidate urls and grant access if either is shared, since the client cannot know in advance whether the requested path names an item or a grouping folder.
This comment has been minimized.
This comment has been minimized.
Oleksii-Klimov
approved these changes
Sep 14, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a user who accepted a share invitation for a specific skill (not its containing folder) got 403 when requesting that skill's metadata via
/v2/metadata/skills/{bucket}/{path}.Applicable issues
Description of changes
ControllerSelectornow passes both the item-shaped and folder-shaped candidate urls for this route to the controller.ComplexResourceMetadataControllerchecks permissions for both candidates and grants access if either is shared, since the client cannot know in advance whether the requested path names a skill item or a grouping folder.ComplexResourceService.getMetadatanow coerces the resource to folder-shape before listing children, since the resource it receives may no longer be folder-shaped for a genuine grouping-folder path.testItemShareInheritsMetadataAccesscovering the exact bug scenario.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.