fix(fixtures): pack under a canonical name so the suite works on any branch - #875
Merged
PolinaGurinovich97 merged 1 commit intoSep 14, 2026
Merged
Conversation
PolinaGurinovich97
requested review from
Alexander-Kezik,
hhharmEpm,
valerydluski and
ya092
as code owners
September 14, 2026 19:42
This was referenced Sep 14, 2026
Merged
…branch
`npm pack` names its output after `package.json#version` and cannot be told
otherwise, so the packed artifact is `epam-ai-dial-ui-kit-0.0.0.tgz` on
`development` and `epam-ai-dial-ui-kit-0.14.0.tgz` on `release-0.14`. Two
places pinned the `0.0.0` spelling — all ten fixture manifests and the
`--from-tarball` argument in `verify:distribution` — so on a release branch
every fixture failed to install:
npm error enoent ENOENT: no such file or directory, open
'…/fixtures/.tarballs/epam-ai-dial-ui-kit-0.0.0.tgz'
and `Verify package distribution` reported ten regressions that were really
one wrong path. It fails that way for any PR opened against a release branch,
which is how it surfaced on the 0.14 cherry-pick of #872.
The packed tarball is now renamed to one canonical, version-free name that
both the fixtures and the export-surface check point at, and the runner fails
loudly if the pack step leaves anything other than exactly one `.tgz` behind.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PolinaGurinovich97
force-pushed
the
fix/fixtures-version-agnostic-tarball
branch
from
September 14, 2026 19:50
4d24d12 to
cf12e53
Compare
PolinaGurinovich97
deleted the
fix/fixtures-version-agnostic-tarball
branch
September 14, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Verify package distributionfails on every PR opened against a release branch, whatever the PR contains. It surfaced on #873, the 0.14 cherry-pick of #872, where all ten fixtures failed with:fixtures/run-all.mjsrunsnpm pack, which names its output afterpackage.json#versionand cannot be told otherwise. Every fixture pins that filename literally:On
developmentthe version is0.0.0, so the two agree and the job is green. Onrelease-0.14the version is0.14.0, the tarball is packed asepam-ai-dial-ui-kit-0.14.0.tgz, and nothing resolves — so the suite reports ten regressions that are really one wrong path, and the identical commit is green ondevelopmentand red on the release branch.Change
The packed artifact is renamed to one canonical, version-free name —
ai-dial-ui-kit.tgz— which is what all ten fixtures now pin. The version stops taking part in the path, so the job behaves the same ondevelopmentand on anyrelease-*branch. The runner also fails loudly if the pack step leaves anything other than exactly one.tgzbehind, instead of letting ten installs fail one after another.Verification
npm run fixtures:run-alllocally: all 10 fixtures pass end-to-end, built and installed from the renamed tarball.npm run lintandnpm run typecheckare green.The release-branch case — the one that was broken — is verified by the same job running on #873 once this is cherry-picked there.
🤖 Generated with Claude Code