fix: drop the reveal toggle from a disabled PasswordInput (Issue epam/ai-dial-chat#8791) - #878
Merged
PolinaGurinovich97 merged 1 commit intoSep 14, 2026
Conversation
…/ai-dial-chat#8791) A disabled `PasswordInput` (2.0) masked its value correctly but still drew the reveal button next to it, disabled. The design draws a masked field with nothing after it — ai-dial-chat#8791 is exactly that state: a toolset's OAuth client secret, disabled once the user has logged in — and a control whose only two outcomes are both unreachable is space spent on nothing. The toggle is now absent while `disabled`, and masking resets with it: a field that is disabled and then enabled again comes back masked rather than silently restoring an earlier reveal. That second half matters on its own — a form that locks its inputs during a request used to hand the field back revealed, with no pressed toggle on screen to explain why the secret was readable. Nothing changes for an enabled field. The spec and the Storybook description that documented the disabled-but-present toggle now cover its absence and the re-enable path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PolinaGurinovich97
requested review from
Alexander-Kezik,
hhharmEpm,
valerydluski and
ya092
as code owners
September 14, 2026 20:25
PolinaGurinovich97
deleted the
fix/password-input-disabled-toggle-release
branch
September 14, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #876, which was merged into the wrong branch — see below. Same commit as #874 (already on
development), cherry-picked ontorelease-0.14without conflicts.What happened to #876
#876 was opened with its base set to
fix/optional-editor-peers-build-0.14(the head branch of #873) so that it could inherit theVerify package distributionfix and keep its own diff to one commit. It was then merged into that branch rather than intorelease-0.14, and #873's branch had already been deleted when #873 merged — so the merge landed on a branch nothing tracks, andrelease-0.14never received the fix. My mistake for stacking it: a stacked base is only safe while everyone knows the merge order, and that branch was already gone.This PR is based directly on
release-0.14, so merging it puts the fix where it belongs.The fix
A disabled
PasswordInput(2.0) masked its value correctly but still drew the reveal button next to it, disabled. The design draws a masked field with nothing after it — ai-dial-chat#8791 is exactly that state: a toolset's OAuth client secret, disabled once the user has logged in.disabled.typestayspasswordwhile disabled rather than relying on the toggle's absence:Inputputs the value of a disabled non-password field in a tooltip.No API change; an enabled field behaves exactly as before.
Note on the gate
Verify package distributionwill fail on this PR until #877 merges. That job is broken onrelease-0.14for every PR, whatever it contains: the fixtures pinepam-ai-dial-ui-kit-0.0.0.tgzwhile a release branch packs…-0.14.0.tgz. #877 is the cherry-pick that fixes it, verified end-to-end on this branch (all 10 fixtures, export-surface parity, pack contents). Merging #877 first makes this PR's gate meaningful.Verification
npm run typecheck— green.PasswordInputspec — 8/8, including the rewritten disabled case (no toggle) and the new reveal → disable → enable case.🤖 Generated with Claude Code