feat: [app] add interceptable command to skip guardrails #346 - #351
Draft
Azamat0315277 wants to merge 6 commits into
Draft
Azamat0315277 wants to merge 6 commits into
Azamat0315277 wants to merge 6 commits into
Conversation
3 tasks
…ake it interceptable
Azamat0315277
force-pushed
the
346-app-add-interceptable-command-to-skip-guardrails
branch
from
May 6, 2026 11:14
697d191 to
e87b535
Compare
Contributor
Author
|
/deploy-review
|
Contributor
|
seems good now. I want to ensure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Renames
skip_out_of_scope_checktocmd_skip_guardrailsand migrates it from a static chain input to an interceptable state variable, consistent with the existingCMD_*command pattern.Changes:
SKIP_OUT_OF_SCOPE_CHECK→CMD_SKIP_GUARDRAILSinDialAppSettingsChainParameters.skip_out_of_scope_check()helper and itsSKIP_OUT_OF_SCOPE_CHECKkey fromChainParametersConfigCMD_SKIP_GUARDRAILStoStateVarsConfigand populate it ininit_state(alongside otherCMD_*flags)OutOfScopeCheckernow reads the flag from state instead of chain inputsskip_guardrailsas anInterceptableCommandinCommandsInterceptorChecklist
Reviewenvironment.Status
Draft
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.