feat: add dataset argument support to DataQueryTool #379 - #380
Draft
veryniceuser wants to merge 11 commits into
Draft
veryniceuser wants to merge 11 commits into
veryniceuser wants to merge 11 commits into
Conversation
- flag toggle between old and new processing - descriptive error message when provided dataset source id is wrong
Contributor
Author
|
/deploy-review
|
`FieldValidationInfo` from pydantic_core has been deprecated; switch the data query tool schema validator to use `pydantic.ValidationInfo` instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ataset_arg_to_data_query_tool
Contributor
Author
|
/deploy-review
|
veryniceuser
marked this pull request as ready for review
May 29, 2026 09:47
Contributor
Author
|
/deploy-review
|
Contributor
Author
|
/deploy-review
|
navalnica
reviewed
May 30, 2026
| " datasets=['BIS:WS_OTC_DERIV2(1.0)'] and query='OTC derivatives'." | ||
| ) | ||
| ) | ||
| datasets: list[str] | None = Field( |
Contributor
There was a problem hiding this comment.
can we simplify the prompt? it's large for an arg description
navalnica
reviewed
May 30, 2026
| description=( | ||
| "Source IDs of datasets the user EXPLICITLY named, taken verbatim" | ||
| " from the Available_Datasets tool response.\n" | ||
| "\n" |
Contributor
There was a problem hiding this comment.
let's store args descriptions along with the tool description - in the tool's config. this allows overwrites in client configs
also, lets use triple quotes strings for better readability
…ataset_arg_to_data_query_tool
veryniceuser
marked this pull request as draft
June 15, 2026 07:45
…ataset_arg_to_data_query_tool
…ataset_arg_to_data_query_tool
Contributor
Author
|
/deploy-review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Checklist
Reviewenvironment.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.