Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
SDMX responses were parsed synchronously on the event loop; large data messages take seconds of CPU-bound parsing and stall every concurrent request. Both parse paths now run in a worker thread via
asyncio.to_thread, mirroring the existing_data_msg_to_dataframeoffload indataset.py. Threaded XML parses inAsyncSdmxClientall run withstructure=Noneand build private structures, so they stay fully parallel; the proxy v30 data parse carries a sharedDataStructureDefinitionthat the reader attaches to the message and mutates while parsing (msg.structure...getdefault(...)), so dsd-bearing parses are serialized with a module-levelthreading.Lock._parse_responseviaasyncio.to_threadinAsyncSdmxClient._fetchStatGptSdmxProxyDataReaderconvert viaasyncio.to_threadinAsyncStatGptSdmxProxyClient._proxy_data_PARSE_DSD_LOCKguardingreader.convertwhen adsdis passed (no_parse_responsecaller currently does; the proxy data path does)Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.