fix: resolve to the World aggregate only on explicit wording #674 - #672
Draft
veryniceuser wants to merge 1 commit into
Draft
veryniceuser wants to merge 1 commit into
veryniceuser wants to merge 1 commit into
Conversation
… wording The normalization prompt let the model treat queries with no geography as global, injecting a spurious "World" reference area that later fails dimension selection (no World value in many datasets) and returns "No data was found for Country/Reference area World". Scope the World rewrite (#438) to EXPLICIT global/worldwide wording and forbid adding a geography when none is mentioned. This upstreams the swissre channel-config override validated in the swissre data-query eval, so that override can be removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
/deploy-review
|
veryniceuser
changed the title
veryniceuser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normalization prompt let the model treat queries with no geography as global, injecting a spurious "World" reference area that later fails dimension selection (no World value in many datasets) and returns "No data was found for Country/Reference area World".
Scope the World rewrite (#438) to EXPLICIT global/worldwide wording and forbid adding a geography when none is mentioned.
Applicable issues
Description of changes
Checklist
ReviewenvironmentBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.