Repository navigation
fix: test-round UX — auto-scroll, truncated replies, publish flow, modal close - #41
Merged
Merged
Conversation
…al close - chat auto-scroll: a bottom sentinel scrollIntoView follows whichever ancestor actually scrolls (the thread div is not the scrolling element on every admin layout), keeping the stick-to-bottom threshold behavior - truncated replies: assistant_text now accumulates as finalText and on stream end a reply shorter than finalText is reconciled to it — lost trailing delta frames can no longer cut a message off mid-word - publish from chat now navigates to Started (and refreshes the lists) so the published topic is immediately visible - Review & publish opened EMPTY for a rejected/list draft: the dialog reads summary/type, the list provided snippet/typeLabel — fields now mapped, and the publish call passes the chosen type - the publish modal closes via backdrop click and a new × button Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4 of the 8 findings from Robbert's first structured test round:
scrollTopwrites were no-ops. A bottom-sentinelscrollIntoView({block:'nearest'})now follows whichever ancestor scrolls; the existing scrolled-up-to-read guard stays.assistant_textnow accumulates asfinalText, and on stream end a shorter reply is reconciled to it. The result-time rule is untouched (the guard legitimately flushes a trailing delta afterresult). Regression test included.summary/type; the list rows carriedsnippet/typeLabel. Fields now mapped, and the list-publish path passes the chosen type through.Rebuilt
assets/dist. Gates: JS 100 ✓ · PHPUnit 133 ✓ · PHPStan ✓ · PHPCS ✓🤖 Generated with Claude Code